| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: clarify equalTupleDescs() |
| Date: | 2024-03-13 18:43:12 |
| Message-ID: | e28182e8-07e6-4ed7-9123-970b894abfa9@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I looked at this patch today. I went through all the calls switched to
equalRowTypes, and AFAIK all of them are correct - all the places
switched to equalRowTypes() only need the weaker checks.
There's only two places still calling equalTupleDescs() - relcache
certainly needs that, and so does the assert in execReplication().
As for attndims, I agree equalRowTypes() should not check that. We're
not really checking that anywhere, it'd be quite weird to start with it
here. Especially if the plan is to remove it entirely.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeremy Schneider | 2024-03-13 18:47:00 | Re: Reports on obsolete Postgres versions |
| Previous Message | Tom Lane | 2024-03-13 18:39:49 | Re: Reports on obsolete Postgres versions |