| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: clarify equalTupleDescs() |
| Date: | 2024-03-17 06:12:19 |
| Message-ID: | 51cefcd9-3c08-4d86-a9ee-f1dc6d8c4cf2@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 13.03.24 19:43, Tomas Vondra wrote:
> I looked at this patch today. I went through all the calls switched to
> equalRowTypes, and AFAIK all of them are correct - all the places
> switched to equalRowTypes() only need the weaker checks.
>
> There's only two places still calling equalTupleDescs() - relcache
> certainly needs that, and so does the assert in execReplication().
>
> As for attndims, I agree equalRowTypes() should not check that. We're
> not really checking that anywhere, it'd be quite weird to start with it
> here. Especially if the plan is to remove it entirely.
Thanks for checking this again. I have committed the patch as it was
presented then.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2024-03-17 06:31:00 | Simplify backtrace_functions GUC code |
| Previous Message | Bharath Rupireddy | 2024-03-17 06:07:58 | Re: Switching XLog source from archive to streaming when primary available |