Re: replace magic num in struct cachedesc with CATCACHE_MAXKEYS

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Junwang Zhao <zhjwpku(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: replace magic num in struct cachedesc with CATCACHE_MAXKEYS
Date: 2024-08-23 13:02:11
Message-ID: e18dd4db-1224-47ec-94b7-4d803140faae@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 15.08.24 12:25, Junwang Zhao wrote:
> I noticed that there is a magic number which can be replaced by CATCACHE_MAXKEYS
> in struct cachedesc, I checked some other struct like CatCache, CatCTup, they
> all use CATCACHE_MAXKEYS.

The "syscache" is the only user of the "catcache" right now. But I
think they are formally separate. So I don't think the "4" in the
syscache is necessarily the same as CATCACHE_MAXKEYS. For example,
increasing CATCACHE_MAXKEYS, hypothetically, wouldn't by itself make the
syscache support more than 4 keys.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2024-08-23 13:17:17 Re: Enable data checksums by default
Previous Message Alexander Korotkov 2024-08-23 12:58:46 Re: POC, WIP: OR-clause support for indexes