| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Ankit Kumar Pandey <itsankitkp(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Check return value of pclose() correctly |
| Date: | 2022-11-15 14:52:54 |
| Message-ID: | e185b889-dc0b-f49a-1260-3e152a69bef8@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 02.11.22 16:26, Ankit Kumar Pandey wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: tested, passed
> Documentation: tested, passed
>
> Hi Peter,
> This is a review of the pclose return value check patch:
>
> Contents & Purpose:
> Purpose of this patch is to properly handle return value of pclose (indirectly, return from ClosePipeStream).
>
> Initial Run:
> The patch applies cleanly to HEAD. The regression tests all pass
> successfully against the new patch.
>
> Conclusion:
> At some places pclose return value is handled and this patch adds return value check for remaining values.
> Implementation is in sync with existing handling of pclose.
Committed. Thanks for the review.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2022-11-15 14:58:57 | Re: dynamic result sets support in extended query protocol |
| Previous Message | Karthik Jagadish (kjagadis) | 2022-11-15 14:45:37 | Vacuumdb --force-index-cleanup option not available in postgres 12.9 |