| From: | Ankit Kumar Pandey <itsankitkp(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: Check return value of pclose() correctly |
| Date: | 2022-11-02 15:26:53 |
| Message-ID: | 166740281339.1122.15508017124113465236.pgcf@coridan.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: tested, passed
Hi Peter,
This is a review of the pclose return value check patch:
Contents & Purpose:
Purpose of this patch is to properly handle return value of pclose (indirectly, return from ClosePipeStream).
Initial Run:
The patch applies cleanly to HEAD. The regression tests all pass
successfully against the new patch.
Conclusion:
At some places pclose return value is handled and this patch adds return value check for remaining values.
Implementation is in sync with existing handling of pclose.
- Ankit K Pandey
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-11-02 15:37:35 | Re: spinlock support on loongarch64 |
| Previous Message | Daniel Verite | 2022-11-02 15:04:02 | Re: psql: Add command to use extended query protocol |