From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Typo in insert.sgml |
Date: | 2017-08-28 01:34:04 |
Message-ID: | e133c86c-55ae-0ad6-b25c-1a73cbf888b7@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 6/20/17 15:03, David G. Johnston wrote:
> On Tuesday, June 20, 2017, Robert Haas <robertmhaas(at)gmail(dot)com
> <mailto:robertmhaas(at)gmail(dot)com>> wrote:
>
> On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com <javascript:;>> wrote:
> > On 6/18/17 03:16, Julien Rouhaud wrote:
> >> Patch attached.
> >
> > This was not a typo, this was intentional.
>
> To me, Julien's change seems to make it easier to understand, but
> maybe I'm misunderstanding what it's trying to say in the first place.
>
>
> Maybe
>
> [...] that are not identity columns in <literal>tbl2</literal>. Values
> for identity columns will come from the sequence generators for
> <literal>tbl2</literal>.
>
> Otherwise I'd drop the word "continue" altogether and just say "but will
> use the sequence counters for".
I have committed something along those lines.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2017-08-28 01:39:28 | Re: pgbench: faster version of tpcb-like transaction |
Previous Message | Michael Malis | 2017-08-28 01:03:19 | Re: Re: Poor cost estimate with interaction between table correlation and partial indexes |