Re: Typo in insert.sgml

From: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Typo in insert.sgml
Date: 2017-06-20 19:03:43
Message-ID: CAKFQuwatuFwvr_61Afdm0S2Kb3VWzH6xqJbxdAacu3t-LS6yig@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tuesday, June 20, 2017, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com <javascript:;>> wrote:
> > On 6/18/17 03:16, Julien Rouhaud wrote:
> >> Patch attached.
> >
> > This was not a typo, this was intentional.
>
> To me, Julien's change seems to make it easier to understand, but
> maybe I'm misunderstanding what it's trying to say in the first place.
>
>
Maybe

[...] that are not identity columns in <literal>tbl2</literal>. Values for
identity columns will come from the sequence generators for
<literal>tbl2</literal>.

Otherwise I'd drop the word "continue" altogether and just say "but will
use the sequence counters for".

David J.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Hernández Tortosa 2017-06-20 19:04:24 Re: [JDBC] Channel binding support for SCRAM-SHA-256
Previous Message Alvaro Herrera 2017-06-20 18:54:25 Re: Optional message to user when terminating/cancelling backend