| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Remove MSVC scripts from the tree |
| Date: | 2023-12-07 07:07:42 |
| Message-ID: | e0011be8-c739-4f9e-aa81-1454c70309fc@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 06.12.23 21:52, Andrew Dunstan wrote:
>
> On 2023-12-06 We 12:24, Peter Eisentraut wrote:
>> On 06.12.23 17:27, Andrew Dunstan wrote:
>>> But the VS2019 compiler implements enough of C99 to pass our meson
>>> test, unlike VS2017. Maybe the test is too strict. After all, we know
>>> we can in fact build with the earlier versions.
>>
>> I just realized that the C99 test is actually our own, not provided by
>> meson. (See "c99_test" in meson.build.)
>>
>> Can you try disabling a few bits of that to see what makes it pass for
>> you? I suspect it's the structfunc() call.
>
>
> Yes, if I comment out the call to structfunc() the test passes on VS2017
> (compiler version 19.15.26726)
This is strange, because we use code like that in the tree. There must
be some small detail that trips it up here.
Perhaps try moving the definition of struct named_init_test outside of
the function, or make it a typedef.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Drouvot, Bertrand | 2023-12-07 07:49:42 | Re: Synchronizing slots from primary to standby |
| Previous Message | Li, Yong | 2023-12-07 07:06:50 | Proposal to add page headers to SLRU pages |