| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | NINGWEI CHEN <chen(at)sraoss(dot)co(dot)jp>, pgsql-hackers(at)lists(dot)postgresql(dot)org, buildfarm(at)sraoss(dot)co(dot)jp |
| Subject: | Re: Remove MSVC scripts from the tree |
| Date: | 2023-12-06 20:52:10 |
| Message-ID: | 34d6a8d6-bfcd-1123-fa8e-8fe7456c3e62@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-12-06 We 12:24, Peter Eisentraut wrote:
> On 06.12.23 17:27, Andrew Dunstan wrote:
>> But the VS2019 compiler implements enough of C99 to pass our meson
>> test, unlike VS2017. Maybe the test is too strict. After all, we know
>> we can in fact build with the earlier versions.
>
> I just realized that the C99 test is actually our own, not provided by
> meson. (See "c99_test" in meson.build.)
>
> Can you try disabling a few bits of that to see what makes it pass for
> you? I suspect it's the structfunc() call.
Yes, if I comment out the call to structfunc() the test passes on VS2017
(compiler version 19.15.26726)
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2023-12-06 21:03:12 | Re: Emitting JSON to file using COPY TO |
| Previous Message | Thomas Munro | 2023-12-06 20:43:37 | Re: gai_strerror() is not thread-safe on Windows |