Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak

From: "Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak
Date: 2005-10-21 17:54:09
Message-ID: djb9vu$1k2p$1@news.hub.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


"Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote
>
> ... so definitely worth fixing for 8.1 if we can convince ourselves
> it's correct.
>

Despite the performance, there is one thing I am not exactly sure. Shall we
add "volatile" quanlifier to at least pg_signal_queue? The dangerous place
is PGSemaphoreLock(). If the compiler cache this value somehow, then we are
in trouble, but the original way (check event directly) does not have this
problem.

Regards,
Qingqing

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2005-10-21 18:06:25 Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak
Previous Message Tom Lane 2005-10-21 17:48:22 Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak