| From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: C99 compliance for src/port/snprintf.c |
| Date: | 2018-08-15 18:59:46 |
| Message-ID: | dd48e765-9afe-4695-b2f4-f3cc0c1218e0@2ndQuadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-www |
On 08/15/2018 12:17 PM, Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>
>> Personally, I'd prefer to
>> continue avoiding // comments and intermingled declarations of
>> variables and code on grounds of style and readability.
> ... which I agree with.
>
>
A decade or so ago I would have strongly agreed with you. But the
language trend seems to be in the other direction. And there is
something to be said for declaration near use without having to use an
inner block. I'm not advocating that we change policy, however.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2018-08-15 19:04:12 | questions about the logical decoding implementation |
| Previous Message | Tom Lane | 2018-08-15 18:09:08 | Re: C99 compliance for src/port/snprintf.c |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-08-15 19:18:57 | Re: C99 compliance for src/port/snprintf.c |
| Previous Message | Tom Lane | 2018-08-15 18:09:08 | Re: C99 compliance for src/port/snprintf.c |