| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net> |
| Subject: | Re: C99 compliance for src/port/snprintf.c |
| Date: | 2018-08-15 18:09:08 |
| Message-ID: | 17667.1534356548@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-www |
David Steele <david(at)pgmasters(dot)net> writes:
> On 8/15/18 12:17 PM, Tom Lane wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> Personally, I'd prefer to
>>> continue avoiding // comments and intermingled declarations of
>>> variables and code on grounds of style and readability.
>> ... which I agree with.
> We already have -Wdeclaration-after-statement to prevent mixed
> declarations. Not sure what to do about comments except manual enforcement.
pgindent will change // comments to /* style, so at least on the timescale
of a release cycle, we have enforcement for that.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2018-08-15 18:59:46 | Re: C99 compliance for src/port/snprintf.c |
| Previous Message | Tom Lane | 2018-08-15 18:05:29 | Re: C99 compliance for src/port/snprintf.c |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2018-08-15 18:59:46 | Re: C99 compliance for src/port/snprintf.c |
| Previous Message | Tom Lane | 2018-08-15 18:05:29 | Re: C99 compliance for src/port/snprintf.c |