From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Silence compiler warnings with Python 3.9 |
Date: | 2020-03-24 10:34:55 |
Message-ID: | d9dde1e7-22fd-6a34-3ad1-c878b2881a0f@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2020-03-02 14:22, Peter Eisentraut wrote:
> Starting with Python 3.9, the Python headers contain inline functions
> that fall afoul of our -Wdeclaration-after-statement coding style. In
> order to silence those warnings, I've added some GCC-specific
> contortions to disable that warning for Python.h only. Clang doesn't
> appear to warn about this at all; maybe it recognizes that this is an
> external header file. We could also write a configure check for this if
> we want to be more flexible.
>
> (Attempts to convince upstream to change the coding style were
> unsuccessful (https://bugs.python.org/issue39615).)
My fix in cpython was accepted after all and the issue is no longer
present in the latest alpha (3.9.0a5), so this can be considered closed.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2020-03-24 12:33:57 | Re: Adding a test for speculative insert abort case |
Previous Message | John Naylor | 2020-03-24 10:27:30 | Re: truncating timestamps on arbitrary intervals |