| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Junwang Zhao <zhjwpku(at)gmail(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Crisp Lee <litianxiang01(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us> |
| Subject: | Re: make pg_ctl more friendly |
| Date: | 2024-07-18 17:47:59 |
| Message-ID: | d9525889-c35a-452e-a4c2-b3747fdd6e10@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2024/07/10 11:45, Junwang Zhao wrote:
>> Attached is my suggestion.
>
> The patch LGTM.
+ case POSTMASTER_SHUTDOWN_IN_RECOVERY:
+ print_msg(_(" done\n"));
+ print_msg(_("server shut down because of recovery target settings\n"));
"because of recovery target settings" isn't always accurate.
For example, if the DBA shuts down the server during recovery,
POSTMASTER_SHUTDOWN_IN_RECOVERY can be returned regardless of
the recovery target settings. Should we change the message to
something like "server shut down in recovery" for accuracy?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-07-18 17:50:02 | Re: make pg_ctl more friendly |
| Previous Message | Jacob Champion | 2024-07-18 17:18:20 | Re: Proposal for implementing OCSP Stapling in PostgreSQL |