| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | Junwang Zhao <zhjwpku(at)gmail(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Crisp Lee <litianxiang01(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us> |
| Subject: | Re: make pg_ctl more friendly |
| Date: | 2024-07-18 17:58:00 |
| Message-ID: | 3779303.1721325480@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> writes:
> "because of recovery target settings" isn't always accurate.
> For example, if the DBA shuts down the server during recovery,
> POSTMASTER_SHUTDOWN_IN_RECOVERY can be returned regardless of
> the recovery target settings. Should we change the message to
> something like "server shut down in recovery" for accuracy?
Hmm, I just pushed it with Laurenz's wording. I don't mind
if we change it again, but I'm not sure that there's much
wrong with it as it stands. Keep in mind that the context
is the DBA doing "pg_ctl start". It seems unlikely that
he/she would concurrently do "pg_ctl stop". Even if that
did happen, do we really need to phrase the message to account
for it?
I like Laurenz's wording because it points the user in the
direction of the settings that would need adjustment if an
immediate shutdown wasn't what was expected/wanted. If we
just say "shut down in recovery", that may be accurate,
but it offers little help as to what to do next.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2024-07-18 18:07:18 | Re: Lock-free compaction. Why not? |
| Previous Message | Fujii Masao | 2024-07-18 17:52:10 | Re: Add a GUC check hook to ensure summarize_wal cannot be enabled when wal_level is minimal |