Re: [PATCH] Tab complete EXECUTE FUNCTION for CREATE (EVENT) TRIGGER

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

> Michael Paquier <michael(at)paquier(dot)xyz> writes:
>> On Fri, Oct 26, 2018 at 09:31:48AM +0900, Michael Paquier wrote:
>>> Committed 0001 now which adds tab completion for CREATE TRIGGER.
>
>> And 0002 is committed as well. Thanks for the patches!
>
> The committed patches look sane to me, but should we back-patch into 11?
> This isn't quite a bug fix maybe, but it's inconsistent if v11 server &
> docs recommend this syntax while v11 psql doesn't produce it.

A related issue is whether we should change pg_get_triggerdef() to emit
the new syntax as well (in HEAD only, since it would break things that
parse the output).

- ilmari
--
"I use RMS as a guide in the same way that a boat captain would use
a lighthouse. It's good to know where it is, but you generally
don't want to find yourself in the same spot." - Tollef Fog Heen