Re: [pgsql-hackers-win32] snprintf causes regression tests to fail

From: Nicolai Tufar <ntufar(at)gmail(dot)com>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <mha(at)sollentuna(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: [pgsql-hackers-win32] snprintf causes regression tests to fail
Date: 2005-03-09 12:40:24
Message-ID: d809293905030904403042ddef@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches

Dear all,
After struggling for one week to to integrate FreeBSD's vfprintf.c into
PostgreSQL I finally gave up. It is too dependent on underlying
FreeBSD system functions. To incorporate it into PostgreSQL we need
to move vfprintf.c file itself, two dozen files form gdtoa and a half
a dozen __XXtoa.c files scattered in apparently random fashion all
around FreeBSD source tree.

Instead I researched some other implementations of snprintf on
the web released under a license compatible with PostgreSQL's.
The most suitable one I have come upon is Trio
[http://daniel.haxx.se/projects/trio/]
It is distributed under a MIT-like license which, I think will be
compatible with us.

What do you think about it? Shall I abandon FreeBSD and go ahead
ıncorporatıng Trıo?

And by the way, what ıs the conclusıon of snprıntf() vs. pg_snprintf()
and UNIX libraries discussion a week ago? Which one shall
I implement?

Regards,
Nicolai Tufar

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-03-09 14:22:21 Re: Current CVS parallel test lock
Previous Message Oleg Bartunov 2005-03-09 12:31:46 Re: fool-toleranced optimizer

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message pgsql 2005-03-09 15:38:27 Re: [pgsql-hackers-win32] snprintf causes regression
Previous Message Rodrigo Moreno 2005-03-08 20:37:30 Connection is closed in pg801 using pgadmin3

Browse pgsql-patches by date

  From Date Subject
Next Message pgsql 2005-03-09 15:38:27 Re: [pgsql-hackers-win32] snprintf causes regression
Previous Message Neil Conway 2005-03-09 12:05:34 Re: trivial refactoring of WaitOnLock