Re: psql: \d+ show tablespace of indices

From: "Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu>
To: pgsql-patches(at)postgresql(dot)org
Subject: Re: psql: \d+ show tablespace of indices
Date: 2005-06-04 02:10:16
Message-ID: d7r2m2$202j$1@news.hub.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


"Neil Conway" <neilc(at)samurai(dot)com> writes
> On Thu, 2005-06-02 at 22:15 -0400, Tom Lane wrote:
> > Does that look better or worse to you?
>
> I agree the patch's format is a bit off. What about
>
> "mi" btree (i), tablespace "testspace"
>
> "PRIMARY KEY" is currently separated from the rest of the index
> description via a comma -- although on the other hand the column list
> isn't preceded by a comma. Perhaps this whole format should be
> rethought?
>

yes, you are right, both forms you showed up are better than mine - the
reason I use that format is because add_tablespace_footer() prints a
"Tablespace: \"tablespace_name\"" in the PQExpBufferData. I could hack the
content in the buffer to make it looks better. Is this acceptable?

Regards,
Qingqing

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message John Hansen 2005-06-04 02:36:58 Re: executing OS programs from pg
Previous Message Luke Lonergan 2005-06-03 22:15:19 Re: NOLOGGING option, or ?

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-06-04 02:59:43 Re: psql: \d+ show tablespace of indices
Previous Message Neil Conway 2005-06-04 02:07:33 Re: Unused variable in explain.c