Re: psql: \d+ show tablespace of indices

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: psql: \d+ show tablespace of indices
Date: 2005-06-04 02:59:43
Message-ID: 200506040259.j542xhT19617@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Qingqing Zhou wrote:
>
> "Neil Conway" <neilc(at)samurai(dot)com> writes
> > On Thu, 2005-06-02 at 22:15 -0400, Tom Lane wrote:
> > > Does that look better or worse to you?
> >
> > I agree the patch's format is a bit off. What about
> >
> > "mi" btree (i), tablespace "testspace"
> >
> > "PRIMARY KEY" is currently separated from the rest of the index
> > description via a comma -- although on the other hand the column list
> > isn't preceded by a comma. Perhaps this whole format should be
> > rethought?
> >
>
> yes, you are right, both forms you showed up are better than mine - the
> reason I use that format is because add_tablespace_footer() prints a
> "Tablespace: \"tablespace_name\"" in the PQExpBufferData. I could hack the
> content in the buffer to make it looks better. Is this acceptable?

Yes, I am thinking you should replace the string "Tablespace:" with a
char pointer that is passed to the function and can be tailored to the
specific use.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2005-06-04 03:56:46 Precedence of %
Previous Message John Hansen 2005-06-04 02:36:58 Re: executing OS programs from pg

Browse pgsql-patches by date

  From Date Subject
Next Message Ron Mayer 2005-06-04 06:05:43 Re: Oracle date type compat. functions: next_day, last_day,
Previous Message Qingqing Zhou 2005-06-04 02:10:16 Re: psql: \d+ show tablespace of indices