From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de> |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: [HACKERS] removing abstime, reltime, tinterval.c, spi/timetravel |
Date: | 2018-10-12 16:40:42 |
Message-ID: | d78dcc0e-9879-3b8e-b901-aa519b91ee98@2ndQuadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 10/12/2018 12:20 PM, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
>> I'm asking again, what exactly do we test by having these types in the
>> dump? They're bog standard types, there's nothing new for pg_dump to
>> test with them. No weird typmod rules, no weird parse-time type mapping,
>> nothing?
> That's a pretty fair point. The types' I/O functions will be exercised
> well enough by the regression tests themselves, and it's hard to see what
> more test coverage is gained by including them in pg_dump/pg_upgrade
> testing. Maybe we should just drop those tables and be done with it.
>
If you're happy with that then go for it. It will be less work for me ;-)
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2018-10-12 16:42:10 | Re: partition tree inspection functions |
Previous Message | Robert Haas | 2018-10-12 16:39:15 | Re: partition tree inspection functions |