Re: Postgres perl module namespace

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Noah Misch <noah(at)leadboat(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Erik Rijkers <er(at)xs4all(dot)nl>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Postgres perl module namespace
Date: 2022-04-18 17:28:40
Message-ID: d74da58b-cfee-4fea-a31a-439921c0feb0@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2022-04-18 Mo 11:52, Noah Misch wrote:
> On Mon, Apr 18, 2022 at 07:15:30AM -0700, Andres Freund wrote:
>> I just, again, tried to backport a test as part of a bugfix. The
>> renaming between 14 and 15 makes that task almost comically harder. The
>> only way I see of dealing with that for the next 5 years is to just
>> never backpatch tests to < 15. Which seems like a bad outcome.

I'm not sure how often we do things like that. But I don't agree it's
impossibly hard, although I can see it might be a bit annoying.

> For what it's worth, to back-patch TAP suite changes, I've been using this
> script (works on a .p[lm] file or on a patch file):
>
> ==== bin/tap15to14
> #! /bin/sh
>
> # This translates a PostgreSQL 15 TAP test into a PostgreSQL 14 TAP test
>
> sed -i~ '
> s/PostgreSQL::Test::Cluster/PostgresNode/g
> s/PostgreSQL::Test::Utils/TestLib/g
> s/PostgresNode->new/get_new_node/g
> ' -- "$@"
>
> grep -w subtest -- "$@"
> ====
>

Yeah, that should take care of most of it.

>> Except that it's *way* too late I would argue that this should just
>> straight up be reverted until that aspect is addressed. It's a
>> maintenance nightmare.
> I do feel PostgreSQL has been over-eager to do cosmetic refactoring. For me,
> this particular one has been sort-of-tolerable.

There were reasons beyond being purely cosmetic for all the changes.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2022-04-18 17:32:33 Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman
Previous Message Tom Lane 2022-04-18 17:20:54 Re: TRAP: FailedAssertion("HaveRegisteredOrActiveSnapshot()", File: "toast_internals.c", Line: 670, PID: 19403)