Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman
Date: 2022-04-18 17:32:33
Message-ID: 3a9ac72a-00b5-e56c-f4a8-05fc4d184f10@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


On 2022-04-17 Su 19:49, Michael Paquier wrote:
> On Sun, Apr 17, 2022 at 10:56:08AM -0400, Andrew Dunstan wrote:
>> I don't really think it's Cluster.pm's business to deal with that. It
>> takes an install path as given either explicitly or implicitly.
>>
>> It shouldn't be too hard to get Makefile.global to install valgrind
>> wrappers into the tmp_install/bin directory.
> Or what gets used in just a wrapper of the contents of bin/ that get
> enforced to be first in PATH?

That seems likely to be difficult. For example pg_ctl might find its
colocated postgres rather than the valgrind wrapper. Ditto initdb.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2022-04-18 21:45:11 Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman
Previous Message Tom Lane 2022-04-18 16:17:17 pgsql: Avoid invalid array reference in transformAlterTableStmt().

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-04-18 17:43:52 Re: Postgres perl module namespace
Previous Message Andrew Dunstan 2022-04-18 17:28:40 Re: Postgres perl module namespace