| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: libpq error message refactoring |
| Date: | 2022-09-23 02:00:00 |
| Message-ID: | d5dddca7-9bdc-ee18-1ec9-ee21f8302d4a@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 22.09.22 17:42, Andres Freund wrote:
> This patch has been failing for a while:
> https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/39/3854
>
> Interestingly, previously the error only happened when targetting windows, but
> meson also shows it on freebsd.
>
> It's not the cause of this failure, I think, but doesn't appendPQExpBufferVA
> need to be added to exports.txt?
I don't want to make that function available to users of libpq, just use
it inside libpq across .c files. Is there no visibility level for that?
Is that also the problem in the freebsd build?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-09-23 02:27:27 | Re: libpq error message refactoring |
| Previous Message | Bharath Rupireddy | 2022-09-23 00:35:36 | Re: binary version of pg_current_wal_insert_lsn and pg_walfile_name functions |