Re: tablesync patch broke the assumption that logical rep depends on?

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Noah Misch <noah(at)leadboat(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: tablesync patch broke the assumption that logical rep depends on?
Date: 2017-04-21 14:09:09
Message-ID: d42969ae-fac8-f116-2434-e7bce37f7ce1@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 4/20/17 14:29, Petr Jelinek wrote:
> + /* Find unused worker slot. */
> + if (!w->in_use)
> {
> - worker = &LogicalRepCtx->workers[slot];
> - break;
> + worker = w;
> + slot = i;
> + }

Doesn't this still need a break? Otherwise it always picks the last slot.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2017-04-21 14:09:54 Re: tablesync patch broke the assumption that logical rep depends on?
Previous Message Petr Jelinek 2017-04-21 14:04:13 Re: Interval for launching the table sync worker