| From: | NikhilS <nikkhils(at)gmail(dot)com> |
|---|---|
| To: | "Trevor Hardcastle" <chizu(at)spicious(dot)com> |
| Cc: | "Bruce Momjian" <bruce(at)momjian(dot)us>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: CREATE TABLE LIKE INCLUDING INDEXES support |
| Date: | 2007-04-13 05:51:56 |
| Message-ID: | d3c4af540704122251i7997cbb4h75d33e5ef8303376@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Hi Trevor,
> +
> + parent_index_info =
> BuildIndexInfo(parent_index);
The above is not used anywhere else in the code and seems redundant.
>
> +
> + ereport(NOTICE,
> + (errmsg("Index
> \"%s\" cloned.",
> +
> RelationGetRelationName(parent_index))));
DefineIndex will give out a message anyways for unique/primary keys. The
above seems additional to it.
Regards,
Nikhils
--
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Warren Turkal | 2007-04-13 06:44:41 | Re: Vista/IPv6 |
| Previous Message | Josh Berkus | 2007-04-13 04:50:23 | Re: Benchmarking tools for the Postgres, EDB and Oracle Database |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavan Deolasee | 2007-04-13 06:56:29 | Re: Dead Space Map version 3 (simplified) |
| Previous Message | Tom Lane | 2007-04-13 04:38:11 | Re: Strangely Variable Query Performance |