From: | Trevor Hardcastle <chizu(at)spicious(dot)com> |
---|---|
To: | NikhilS <nikkhils(at)gmail(dot)com> |
Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: CREATE TABLE LIKE INCLUDING INDEXES support |
Date: | 2007-04-13 16:42:51 |
Message-ID: | 461FB30B.3020907@spicious.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
NikhilS wrote:
> Hi Trevor,
>
>
> +
> + parent_index_info =
> BuildIndexInfo(parent_index);
>
>
> The above is not used anywhere else in the code and seems redundant.
Yep, pulled that out.
>
> +
> + ereport(NOTICE,
> +
> (errmsg("Index \"%s\" cloned.",
> +
> RelationGetRelationName(parent_index))));
>
>
> DefineIndex will give out a message anyways for unique/primary keys.
> The above seems additional to it.
The original reason for this was the support for copying all indexes,
but it doesn't make much sense now. I've pulled it too.
Thanks for pointing those out. An updated patch is attached.
-Trevor Hardcastle
Attachment | Content-Type | Size |
---|---|---|
like_including_indexes-3.patch | text/plain | 8.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2007-04-13 16:50:33 | Re: [HACKERS] Full page writes improvement, code update |
Previous Message | Simon Riggs | 2007-04-13 16:06:08 | Re: [HACKERS] Full page writes improvement, code update |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2007-04-13 16:50:33 | Re: [HACKERS] Full page writes improvement, code update |
Previous Message | Simon Riggs | 2007-04-13 16:06:08 | Re: [HACKERS] Full page writes improvement, code update |