Re: pgsql: Add viewBox attribute to storage page layout SVG image

From: Joe Conway <mail(at)joeconway(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add viewBox attribute to storage page layout SVG image
Date: 2019-04-29 10:45:56
Message-ID: d2cc39e6-2477-30a8-3bff-c69cefb346aa@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 4/29/19 2:06 AM, Peter Eisentraut wrote:
> On 2019-04-27 17:37, Joe Conway wrote:
>> Add viewBox attribute to storage page layout SVG image
>
> The SVG images are not supposed to be edited. This needs a different
> solution.

If the viewBox attribute is needed to make this work reasonably and the
tool does not produce it, post production editing of the SVG is not such
a bad thing IMHO.

But in any case, if you expect that no one will edit a text-based file
(SVG) that is checked in to git, it ought to be made crystal clear
somewhere, and the README is not currently crystal clear on that point.

Additionally, this should go on the issues list for pg12.

Joe
--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-04-29 13:30:45 Re: pgsql: Add viewBox attribute to storage page layout SVG image
Previous Message Peter Eisentraut 2019-04-29 06:55:45 pgsql: Fix potential catalog corruption with temporary identity columns