Re: pgsql: Add viewBox attribute to storage page layout SVG image

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add viewBox attribute to storage page layout SVG image
Date: 2019-04-29 13:30:45
Message-ID: 19802.1556544645@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Joe Conway <mail(at)joeconway(dot)com> writes:
> On 4/29/19 2:06 AM, Peter Eisentraut wrote:
>> The SVG images are not supposed to be edited. This needs a different
>> solution.

> If the viewBox attribute is needed to make this work reasonably and the
> tool does not produce it, post production editing of the SVG is not such
> a bad thing IMHO.

> But in any case, if you expect that no one will edit a text-based file
> (SVG) that is checked in to git, it ought to be made crystal clear
> somewhere, and the README is not currently crystal clear on that point.

I am confused. Didn't we spend many years looking for a graphics
format that *could* be edited?

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2019-04-29 14:11:26 pgsql: Message fixes
Previous Message Joe Conway 2019-04-29 10:45:56 Re: pgsql: Add viewBox attribute to storage page layout SVG image