Re: pgsql: Detach constraints when partitions are detached

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Detach constraints when partitions are detached
Date: 2019-01-24 05:22:07
Message-ID: d24d40f3-52d7-296c-8e06-5b153c5ba0dd@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2019/01/24 13:58, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
>> Detach constraints when partitions are detached
>
> Hm ... it looks like this fails under -DRELCACHE_FORCE_RELEASE:

Oops, sorry. This is why:

index_close(idx, NoLock);
...
+ if (!idx->rd_index->indisprimary && !idx->rd_index->indisunique)
+ continue;

Attached a fix.

Thanks,
Amit

Attachment Content-Type Size
ae366aa577-fixup.patch text/plain 1.1 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Etsuro Fujita 2019-01-24 07:51:17 pgsql: postgres_fdw: Account for tlist eval costs in estimate_path_cost
Previous Message Tom Lane 2019-01-24 04:58:54 Re: pgsql: Detach constraints when partitions are detached

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-01-24 05:23:04 Re: Thread-unsafe coding in ecpg
Previous Message Tom Lane 2019-01-24 04:58:54 Re: pgsql: Detach constraints when partitions are detached