Re: pgsql: Detach constraints when partitions are detached

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Detach constraints when partitions are detached

Hm ... it looks like this fails under -DRELCACHE_FORCE_RELEASE:

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2019-01-24%2003%3A58%3A02

Core was generated by `postgres: ec2-user regression [local] ALTER TABLE '.
Program terminated with signal 11, Segmentation fault.
#0 0x00000000005f9413 in ATExecDetachPartition (rel=rel(at)entry=0x7f20d6fab080, name=<optimized out>) at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/backend/commands/tablecmds.c:15116
15116 if (!idx->rd_index->indisprimary && !idx->rd_index->indisunique)
#0 0x00000000005f9413 in ATExecDetachPartition (rel=rel(at)entry=0x7f20d6fab080, name=<optimized out>) at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/backend/commands/tablecmds.c:15116
#1 0x0000000000605a95 in ATExecCmd (wqueue=wqueue(at)entry=0x7ffe1afaea28, tab=tab(at)entry=0x1591a10, rel=rel(at)entry=0x7f20d6fab080, cmd=0x155ee08, lockmode=lockmode(at)entry=8) at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/backend/commands/tablecmds.c:4314
#2 0x0000000000607faf in ATRewriteCatalogs (lockmode=8, wqueue=0x7ffe1afaea28) at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/backend/commands/tablecmds.c:4028
#3 ATController (parsetree=parsetree(at)entry=0x1542fc8, rel=<optimized out>, cmds=<optimized out>, recurse=<optimized out>, lockmode=lockmode(at)entry=8) at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/backend/commands/tablecmds.c:3694
#4 0x00000000006086cf in AlterTable (relid=relid(at)entry=32016, lockmode=lockmode(at)entry=8, stmt=stmt(at)entry=0x1542fc8) at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/backend/commands/tablecmds.c:3368
#5 0x0000000000792042 in ProcessUtilitySlow (pstate=pstate(at)entry=0x152ede8, pstmt=pstmt(at)entry=0x1470b18, queryString=queryString(at)entry=0x146fb78 "alter table idxpart detach partition idxpart1;", context=context(at)entry=PROCESS_UTILITY_TOPLEVEL, params=params(at)entry=0x0, queryEnv=queryEnv(at)entry=0x0, completionTag=completionTag(at)entry=0x7ffe1afaefe0 "", dest=0x1470c10) at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/backend/tcop/utility.c:1120
#6 0x00000000007904d6 in standard_ProcessUtility (pstmt=0x1470b18, queryString=0x146fb78 "alter table idxpart detach partition idxpart1;", context=PROCESS_UTILITY_TOPLEVEL, params=0x0, queryEnv=0x0, dest=0x1470c10, completionTag=0x7ffe1afaefe0 "") at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/backend/tcop/utility.c:923
#7 0x000000000078dae5 in PortalRunUtility (portal=0x14d5dd8, pstmt=0x1470b18, isTopLevel=<optimized out>, setHoldSnapshot=<optimized out>, dest=<optimized out>, completionTag=0x7ffe1afaefe0 "") at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/backend/tcop/pquery.c:1175
#8 0x000000000078e5f9 in PortalRunMulti (portal=portal(at)entry=0x14d5dd8, isTopLevel=isTopLevel(at)entry=true, setHoldSnapshot=setHoldSnapshot(at)entry=false, dest=dest(at)entry=0x1470c10, altdest=altdest(at)entry=0x1470c10, completionTag=completionTag(at)entry=0x7ffe1afaefe0 "") at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/backend/tcop/pquery.c:1328
#9 0x000000000078f292 in PortalRun (portal=portal(at)entry=0x14d5dd8, count=count(at)entry=9223372036854775807, isTopLevel=isTopLevel(at)entry=true, run_once=run_once(at)entry=true, dest=dest(at)entry=0x1470c10, altdest=altdest(at)entry=0x1470c10, completionTag=completionTag(at)entry=0x7ffe1afaefe0 "") at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/backend/tcop/pquery.c:796
#10 0x000000000078b02d in exec_simple_query (query_string=0x146fb78 "alter table idxpart detach partition idxpart1;") at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/backend/tcop/postgres.c:1215
#11 0x000000000078c362 in PostgresMain (argc=<optimized out>, argv=argv(at)entry=0x149a548, dbname=0x149a2d8 "regression", username=<optimized out>) at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/backend/tcop/postgres.c:4256
#12 0x00000000004805f8 in BackendRun (port=<optimized out>, port=<optimized out>) at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/backend/postmaster/postmaster.c:4378
#13 BackendStartup (port=0x1490320) at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/backend/postmaster/postmaster.c:4069
#14 ServerLoop () at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/backend/postmaster/postmaster.c:1699
#15 0x0000000000713f60 in PostmasterMain (argc=argc(at)entry=8, argv=argv(at)entry=0x146b6d0) at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/backend/postmaster/postmaster.c:1372
#16 0x0000000000481a63 in main (argc=8, argv=0x146b6d0) at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/backend/main/main.c:228

regards, tom lane