| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Davis <pgsql(at)j-davis(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, jian he <jian(dot)universality(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, alvherre(at)alvh(dot)no-ip(dot)org |
| Subject: | Re: Statistics Import and Export |
| Date: | 2025-02-24 20:53:04 |
| Message-ID: | curtrasm6ylt7es2ukfuals2mh5an72yzxgvyel65mw3ere7qs@nw6m4ffpo4m3 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2025-02-24 15:45:10 -0500, Corey Huinker wrote:
> >
> >
> >
> > I suspect that this is a *really* bad idea. It's very very hard to get
> > inplace
> > updates right. We have several unfixed correctness bugs that are related to
> > the use of inplace updates. I really don't think it's wise to add
> > additional
> > interfaces that can reach inplace updates unless there's really no other
> > alternative (like not being able to assign an xid in VACUUM to be able to
> > deal
> > with anti-xid-wraparound-shutdown systems).
>
>
> In this case, the alternative is an immediate doubling of the size of
> pg_class right after a restore/upgrade.
I don't think that's necessarily true, hot pruning might help some, as afaict
the restore happens in multiple transactions.
But even if that's the case, I don't think it's worth using in place updates
to avoid it. We should work to get rid of them, not introduce them in more
places.
And typically pg_class size isn't the relevant factor, it's pg_attribute etc.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-02-24 20:53:56 | Re: Statistics Import and Export |
| Previous Message | Nathan Bossart | 2025-02-24 20:47:13 | Re: PATCH: warn about, and deprecate, clear text passwords |