| From: | "Anton A(dot) Melnikov" <a(dot)melnikov(at)postgrespro(dot)ru> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | daniel(at)yesql(dot)se, peter(at)eisentraut(dot)org, tgl(at)sss(dot)pgh(dot)pa(dot)us, robertmhaas(at)gmail(dot)com, michael(at)paquier(dot)xyz, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Use XLOG_CONTROL_FILE macro everywhere? |
| Date: | 2025-04-04 23:27:14 |
| Message-ID: | cfaa1778-99f2-4348-8ab7-56be503e6d39@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi!
On 04.04.2025 19:32, Fujii Masao wrote:
> I'm not sure there's clear consensus yet on the changes in the 0001 and
> 0002 patches, and it might not be worth rushing them in right before
> the feature freeze. So for now, I reviewed and updated only the 0003 patch,
> since there seems to be agreement on that one.
>
> I've attached the updated version. It fixes a typo and replaces
> the remaining hardcoded control file name with the XLOG_CONTROL_FILE macro.
Thanks! Looks good for me.
Maybe extend this to perl tests since there are several hardcoded names too?
The patch attached tries to do this.
> How about committing the attached patch first? We can consider applying
> the others later if consensus is reached
Yes, of cause. IMO, this is the best way now.
Best wishes,
--
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| 0004-Use-XLOG_CONTROL_FILE-macro-in-TAP-tests.patch | text/x-patch | 4.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2025-04-04 23:32:48 | Re: Statistics Import and Export |
| Previous Message | Andres Freund | 2025-04-04 23:24:48 | Re: BTScanOpaqueData size slows down tests |