Re: Use XLOG_CONTROL_FILE macro everywhere?

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: "Anton A(dot) Melnikov" <a(dot)melnikov(at)postgrespro(dot)ru>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: daniel(at)yesql(dot)se, peter(at)eisentraut(dot)org, tgl(at)sss(dot)pgh(dot)pa(dot)us, robertmhaas(at)gmail(dot)com, michael(at)paquier(dot)xyz, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Use XLOG_CONTROL_FILE macro everywhere?
Date: 2025-04-04 16:32:57
Message-ID: 18d80eb9-1e7a-4ead-98fe-60efc988954b@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2025/03/28 13:09, Anton A. Melnikov wrote:
> Hi!
>
>> * Patch needs rebase by CFbot
>
> Rebased the patches onto the current master and marked them as v4.

I'm not sure there's clear consensus yet on the changes in the 0001 and
0002 patches, and it might not be worth rushing them in right before
the feature freeze. So for now, I reviewed and updated only the 0003 patch,
since there seems to be agreement on that one.

I've attached the updated version. It fixes a typo and replaces
the remaining hardcoded control file name with the XLOG_CONTROL_FILE macro.

How about committing the attached patch first? We can consider applying
the others later if consensus is reached.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachment Content-Type Size
v5-0001-Use-XLOG_CONTROL_FILE-macro-consistently-for-cont.patch text/plain 10.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2025-04-04 16:36:33 Re: autoprewarm_dump_now
Previous Message Alena Rybakina 2025-04-04 16:30:47 Re: Replace IN VALUES with ANY in WHERE clauses during optimization