From: | Gilles Darold <gilles(at)darold(dot)net> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Tab completion for CREATE TABLE ... AS |
Date: | 2023-11-15 14:26:58 |
Message-ID: | cee947e8-a7f4-4589-b1c2-cd0cc956ac77@darold.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Le 15/11/2023 à 03:58, Michael Paquier a écrit :
> On Thu, Nov 02, 2023 at 07:27:02PM +0300, Gilles Darold wrote:
>> Look like the tab completion for CREATE TABLE ... AS is not
>> proposed.
>>
>> + /* Complete CREATE TABLE <name> AS with list of keywords */
>> + else if (TailMatches("CREATE", "TABLE", MatchAny, "AS") ||
>> + TailMatches("CREATE", "TEMP|TEMPORARY|UNLOGGED", "TABLE", MatchAny, "AS"))
>> + COMPLETE_WITH("SELECT", "WITH");
> There is a bit more than SELECT and WITH as possible query for a CTAS.
> How about VALUES, TABLE or even EXECUTE (itself able to handle a
> SELECT, TABLE or VALUES)?
> --
> Michael
Right, I don't know how I have missed the sql-createtableas page in the
documentation.
Patched v2 fixes the keyword list, I have also sorted by alphabetical
order the CREATE TABLE completion (AS was at the end of the list).
It has also been re-based on current master.
--
Gilles Darold
http://www.darold.net/
Attachment | Content-Type | Size |
---|---|---|
fix-create-as-completion-v2.patch | text/x-patch | 1.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Julien Rouhaud | 2023-11-15 15:03:23 | Re: Fix documentation for pg_stat_statements JIT deform_counter |
Previous Message | Daniel Gustafsson | 2023-11-15 14:25:22 | Re: Allow tests to pass in OpenSSL FIPS mode |