From: | Svetlana Derevyanko <s(dot)derevyanko(at)postgrespro(dot)ru> |
---|---|
To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
Cc: | Maxim Orlov <orlovmg(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Refactoring of pg_resetwal/t/001_basic.pl |
Date: | 2024-03-26 11:53:35 |
Message-ID: | cdba31421408ccb41756a04798c4fd54@postgrespro.ru |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Peter Eisentraut писал(а) 2024-03-25 17:10:
> But MXOFF_SIZE doesn't exist anywhere else. The actual formula uses
> sizeof(MultiXactOffset), which isn't obvious from your patch. So this
> just moves the magic constants around by one level.
>
> I think if we're going to add more symbols, then it has to be done
> consistently in the source code, the documentation, and the tests, not
> just one of them.
>
Hello!
Thank you for your reply.
Attached is the updated version of patch for pg_resetwal test. I added
definitions for MXOFF_SIZE and MXID_SIZE constants in multixact.c (and
replaced use of sizeof(MultiXactId) and sizeof(MultiXactOffset)
accordingly). Also changed multipliers for pg_xact/members/offset on
CLOG_XACTS_PER_PAGE/MULTIXACT_MEMBERS_PER_PAGE/MULTIXACT_OFFSETS_PER_PAGE
both in src/bin/pg_resetwal/t/001_basic.pl and docs, since it seems to
me that this makes things more clear.
What do you think?
Best regards,
Svetlana Derevyanko.
Attachment | Content-Type | Size |
---|---|---|
v2-0001-Refactor-pg_resetwal-t-001_basic.pl.patch | text/x-diff | 6.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tender Wang | 2024-03-26 12:00:36 | Can't find not null constraint, but \d+ shows that |
Previous Message | Nazir Bilal Yavuz | 2024-03-26 11:51:27 | Re: Use streaming read API in ANALYZE |