| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Svetlana Derevyanko <s(dot)derevyanko(at)postgrespro(dot)ru> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Maxim Orlov <orlovmg(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Refactoring of pg_resetwal/t/001_basic.pl |
| Date: | 2024-04-04 01:58:48 |
| Message-ID: | Zg4JWLBHD4xfPGJG@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 26, 2024 at 02:53:35PM +0300, Svetlana Derevyanko wrote:
> What do you think?
>
> +use constant SLRU_PAGES_PER_SEGMENT => 32;
Well, I disagree with what you are doing here, adding a hardcoded
dependency between the test code and the backend code. I would
suggest to use a more dynamic approach and retrieve such values
directly from the headers. See scan_server_header() in
039_end_of_wal.pl as one example. 7b5275eec3a5 is newer than
bae868caf222, so the original commit could have used that, as well.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2024-04-04 02:10:27 | Re: PostgreSQL 17 Release Management Team & Feature Freeze |
| Previous Message | David Rowley | 2024-04-04 01:44:27 | Re: Parent/child context relation in pg_get_backend_memory_contexts() |