Un peu décu : Re: Performance regression with PostgreSQL 11 and partitioning

From: Christophe Courtois <christophe(dot)courtois(at)dalibo(dot)com>
To: Thomas Reiss <thomas(dot)reiss(at)dalibo(dot)com>
Cc: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Un peu décu : Re: Performance regression with PostgreSQL 11 and partitioning
Date: 2018-07-09 12:47:51
Message-ID: cd71cd32-c6ea-8331-820c-7220e678b97f@dalibo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

J'ai eu peur, 7d872c91a3f9d49b56117557cdbb0c3d4c620687 n'est pas en bêta
2 mais bien dans REL_11_STABLE.

J'ai relancé mes scripts avec 10000 partitions vides, un peu à l'arrache
et sans rigueur : la dernière version incluant ce patch est
effectivement souvent moitié plus rapide qu'en 10, mais si je joins deux
tables à 10000 partitions entre elles, ça devient 2 fois plus
catastrophique.

Bref, un sacré progrès quand même. Merci d'avoir porté ça sur hackers.

Le 26/06/2018 à 16:46, Thomas Reiss a écrit :
>
>
> Le 26/06/2018 à 16:43, Alvaro Herrera a écrit :
>> On 2018-Jun-25, Tom Lane wrote:
>>
>>> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
>>>> On 2018-Jun-18, David Rowley wrote:
>>>>> I've attached a patch which cleans up my earlier version and moves the
>>>>> setup of the append_rel_array into its own function instead of
>>>>> sneaking code into setup_simple_rel_arrays(). I've also now updated
>>>>> the comment above find_childrel_appendrelinfo(), which is now an
>>>>> unused function.
>>>
>>>> I checked that this patch fixes the originally reported performance
>>>> regression.
>>>> Unless there are objections, I intend to push this patch tomorrow.
>>>
>>> If find_childrel_appendrelinfo is now unused, we should remove it.
>>
>> Agreed -- thanks for following up. Pushed that way.
>
> Thanks Alvaro, Ashutosh and David.
>
>
>

--
Christophe Courtois
Consultant Dalibo
http://dalibo.com/ - http://dalibo.org/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2018-07-09 12:52:46 Re: How can we submit code patches that implement our (pending) patents?
Previous Message Peter Eisentraut 2018-07-09 12:45:26 Re: missing toast table for pg_policy