Re: [PATCH] pgarchives: parser: handle messages in which Message-ID is missing

From: Célestin Matte <celestin(dot)matte(at)cmatte(dot)me>
To: pgsql-www(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] pgarchives: parser: handle messages in which Message-ID is missing
Date: 2021-11-03 17:05:44
Message-ID: cd426669-d5fb-fe3e-b0c1-28c10866ff28@cmatte.me
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

By the way, loader/load_message.py has a double crash issue, when importing a message raising an IgnorableException:

[...]
During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/srv/pgarchives/local//loader/load_message.py", line 155, in <module>
log_failed_message(listid, "mbox", opt.mbox, ap, e)
File "/srv/pgarchives/local//loader/load_message.py", line 36, in log_failed_message
'err': str(str(err), 'us-ascii', 'replace'),
TypeError: decoding str is not supported

I don't understand what this line is supposed to do (removing non-ascii characters?), but a simple str(err) fixes the issue.

Cheers,
--
Célestin Matte

In response to

Responses

Browse pgsql-www by date

  From Date Subject
Next Message Célestin Matte 2021-11-03 19:01:37 [PATCH] pglister: load_subscribers.py: don't wait for user input when there is nothing to commit
Previous Message Célestin Matte 2021-11-03 17:02:42 [PATCH] pgarchives: parser: handle messages in which Message-ID is missing