Re: [PATCH] pgarchives: parser: handle messages in which Message-ID is missing

On Wed, Nov 3, 2021 at 6:05 PM Célestin Matte <celestin(dot)matte(at)cmatte(dot)me>
wrote:

> By the way, loader/load_message.py has a double crash issue, when
> importing a message raising an IgnorableException:
>
> [...]
> During handling of the above exception, another exception occurred:
>
> Traceback (most recent call last):
> File "/srv/pgarchives/local//loader/load_message.py", line 155, in
> <module>
> log_failed_message(listid, "mbox", opt.mbox, ap, e)
> File "/srv/pgarchives/local//loader/load_message.py", line 36, in
> log_failed_message
> 'err': str(str(err), 'us-ascii', 'replace'),
> TypeError: decoding str is not supported
>
> I don't understand what this line is supposed to do (removing non-ascii
> characters?), but a simple str(err) fixes the issue.
>

It's supposed to remove non-ascii characters.

I think this is a leftover from the py2->py3 conversion. It looks like an
overenthusiastic regexp replacement in the 2to3 tool. See bb5775ef where it
came from. I'll go change it to jut str(err).

--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/>
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>