Re: testing dist tarballs

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: testing dist tarballs
Date: 2023-05-26 07:02:33
Message-ID: ccfbf843-574b-ec0a-d26a-090fc493af4b@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 24.05.23 23:24, Andres Freund wrote:
> First thing I noticed that 'make dist' doesn't work in a vpath, failing in a
> somewhat obscure way (likely because in a vpath build the the copy from the
> source dir doesn't include GNUMakefile). Do we expect it to work?

I don't think so.

> Separately, it's somewhat confusing that we include errcodes.h etc in
> src/backend/utils, rather than its final location, in src/include/utils. It
> works, even without perl, because copying the file doesn't require perl, it's
> just generating it...

The "copying" is actually a symlink, right? I don't think we want to
ship symlinks in the tarball?

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2023-05-26 16:13:25 pgsql: Fix joinclause removal logic to cope with cloned clauses.
Previous Message Jeff Davis 2023-05-26 00:14:08 pgsql: Doc fixes for commit 1e16af8ab5.

Browse pgsql-hackers by date

  From Date Subject
Next Message Yu Shi (Fujitsu) 2023-05-26 07:27:01 BF animal dikkop reported a failure in 035_standby_logical_decoding
Previous Message Michael Paquier 2023-05-26 05:19:38 Re: Allow pg_archivecleanup to remove backup history files