From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: testing dist tarballs |
Date: | 2023-05-27 18:47:13 |
Message-ID: | 20230527184713.32pjrsfgm2pixwmu@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Hi,
On 2023-05-26 09:02:33 +0200, Peter Eisentraut wrote:
> On 24.05.23 23:24, Andres Freund wrote:
> > First thing I noticed that 'make dist' doesn't work in a vpath, failing in a
> > somewhat obscure way (likely because in a vpath build the the copy from the
> > source dir doesn't include GNUMakefile). Do we expect it to work?
>
> I don't think so.
Maybe we should just error out in that case, instead of failing in an obscure
way down the line?
> > Separately, it's somewhat confusing that we include errcodes.h etc in
> > src/backend/utils, rather than its final location, in src/include/utils. It
> > works, even without perl, because copying the file doesn't require perl, it's
> > just generating it...
>
> The "copying" is actually a symlink, right? I don't think we want to ship
> symlinks in the tarball?
Fair point - still seems we should just create the files in the right
directory instead of doing it in the wrong place and then creating symlinks to
make them accessible...
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2023-05-28 03:05:13 | pgsql: doc: PG 16 relnotes, fix "locale" typo and windows locale text |
Previous Message | Jeff Davis | 2023-05-26 18:44:26 | pgsql: ICU: use uloc_getDefault() for initdb. |
From | Date | Subject | |
---|---|---|---|
Next Message | Gurjeet Singh | 2023-05-27 22:17:21 | Document that server will start even if it's unable to open some TCP/IP ports |
Previous Message | Andres Freund | 2023-05-27 18:42:01 | Re: Why does pg_bsd_indent need to be installed? |