| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | amul sul <sulamul(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Dmitry Ivanov <d(dot)ivanov(at)postgrespro(dot)ru>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Erik Rijkers <er(at)xs4all(dot)nl>, Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers-owner(at)postgresql(dot)org |
| Subject: | Re: Declarative partitioning - another take |
| Date: | 2017-02-10 05:54:08 |
| Message-ID: | cc94506c-f34c-4081-09f9-d1d1837a1524@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017/02/09 15:22, amul sul wrote:
> About 0001-Check-partition-strategy-in-ATExecDropNotNull.patch,
> following test is already covered in alter_table.sql @ Line # 1918,
> instead of this kindly add test for list_partition:
>
> 77 +-- cannot drop NOT NULL constraint of a range partition key column
> 78 +ALTER TABLE range_parted ALTER a DROP NOT NULL;
> 79 +
Thanks for the review! You're right. Updated patch attached.
Thanks,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Check-partition-strategy-in-ATExecDropNotNull.patch | text/x-diff | 3.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2017-02-10 06:04:36 | Re: Removal of deprecated views pg_user, pg_group, pg_shadow |
| Previous Message | Tom Lane | 2017-02-10 05:51:54 | Re: Removal of deprecated views pg_user, pg_group, pg_shadow |