Re: BUG #14231: logical replication wal sender process spins when using error traps in function

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Peter Geoghegan <pg(at)heroku(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-bugs(at)postgresql(dot)org, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, blake(at)rcmail(dot)com
Subject: Re: BUG #14231: logical replication wal sender process spins when using error traps in function
Date: 2016-07-20 01:18:06
Message-ID: c97089b5-3a3c-701f-461e-8e46c9fb4a01@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On 07/19/2016 06:22 PM, Tomas Vondra wrote:
>
> I don't expect to have much time to work on this in the next few weeks,
> so if anyone wants to grab this and make it a proper patch, be my guest.

Meh, who am I kidding. I've spent a bit more time hacking on this
anyway. Attached is v3, fixing various thinkos and optimizations, checks
in the code and especially docs explaining the main ideas. It's far from
perfect but much better than the previous two versions.

And it actually performs even better than the previous versions (about
2x faster on the 50k case).

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
slab-reorder-buffer-v3.patch binary/octet-stream 34.6 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Amaury Decreme 2016-07-20 07:27:06 Re: BUG #14261: Hanged randomly in hash_seq_search
Previous Message Michael Paquier 2016-07-19 23:54:47 Re: [BUGS] BUG #14260: psqlODBC does not support sslXXXXX variables