| From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: WIP: new system catalog pg_wait_event |
| Date: | 2023-08-08 08:16:37 |
| Message-ID: | c915434a-3d3a-4135-8f3a-fca0cf22c6ae@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 8/8/23 7:37 AM, Drouvot, Bertrand wrote:
> Hi,
>
> On 8/8/23 5:05 AM, Michael Paquier wrote:
>> On Tue, Aug 08, 2023 at 11:53:32AM +0900, Kyotaro Horiguchi wrote:
>>> As I mentioned in another thread, I'm uncertain about our stance on
>>> the class id of the wait event. If a class acts as a namespace, we
>>> should include it in the view. Otherwise, if the class id is just an
>>> attribute of the wait event, we should make the event name unique.
>>
>> Including the class name in the view makes the most sense to me, FWIW,
>> as it could be also possible that one reuses an event name in the
>> existing in-core list, but for extensions. That's of course not
>> something I would recommend.
>
> Thanks Kyotaro-san and Michael for the feedback. I do agree and will
> add the class name.
>
Please find attached v3 adding the wait event types.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-pg_wait_event.patch | text/plain | 16.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2023-08-08 08:17:51 | Re: [PATCH] psql: Add tab-complete for optional view parameters |
| Previous Message | Peter Smith | 2023-08-08 08:09:20 | Re: Adding a LogicalRepWorker type field |