Re: [PATCH] psql: Add tab-complete for optional view parameters

On Mon, 7 Aug 2023 at 19:49, Christoph Heiss <christoph(at)c8h4(dot)io> wrote:
>
> On Fri, Jan 06, 2023 at 12:18:44PM +0000, Dean Rasheed wrote:
> > Hmm, I don't think we should be offering "check_option" as a tab
> > completion for CREATE VIEW at all, since that would encourage users to
> > use non-SQL-standard syntax, rather than CREATE VIEW ... WITH
> > [CASCADED|LOCAL] CHECK OPTION.
>
> Left that part in for now. I would argue that it is a well-documented
> combination and as such users would expect it to turn up in the
> tab-complete as well. OTOH not against removing it either, if there are
> others voicing the same opinion ..
>

On reflection, I think that's probably OK. I mean, I still don't like
the fact that it's offering to complete with non-SQL-standard syntax,
but that seems less bad than using an incomplete list of options, and
I don't really have any other better ideas.

Regards,
Dean