From: | Tomas Vondra <tv(at)fuzzy(dot)cz> |
---|---|
To: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de> |
Cc: | pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Generational memory allocator |
Date: | 2017-11-23 15:16:08 |
Message-ID: | c903f275-2150-fa52-64bf-dca7b53ebf8d@fuzzy.cz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On 11/23/2017 10:57 AM, Simon Riggs wrote:
> On 23 November 2017 at 11:16, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> Hi,
>>
>> On 2017-11-22 18:48:19 +0000, Simon Riggs wrote:
>>> Generational memory allocator
>>>
>>> Add new style of memory allocator, known as Generational
>>> appropriate for use in cases where memory is allocated
>>> and then freed in roughly oldest first order (FIFO).
>>>
>>> Use new allocator for logical decoding’s reorderbuffer
>>> to significantly reduce memory usage and improve performance.
>>
>> Looks like it's not quite valgrind clean:
>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2017-11-22%2022%3A30%3A01
>
> It doesn't report anything useful that would allow me to fix this.
>
> Please enable some info reporting on the animal.
>
I agree it would be useful to get the valgrind log from the animal, but
I guess you'd need to get valgrind working to fix the issue anyway.
Anyway, the attached patch fixes the issues for me - strictly speaking
the Assert is not needed, but it doesn't hurt.
regards
Tomas
Attachment | Content-Type | Size |
---|---|---|
genalloc-valgrind-fix.patch | text/x-patch | 611 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2017-11-23 18:52:58 | Re: pgsql: Generational memory allocator |
Previous Message | Peter Eisentraut | 2017-11-23 14:51:23 | pgsql: Convert documentation to DocBook XML |