Re: pgsql: Generational memory allocator

On 24 November 2017 at 02:16, Tomas Vondra <tv(at)fuzzy(dot)cz> wrote:
>
>
> On 11/23/2017 10:57 AM, Simon Riggs wrote:
>>
>> On 23 November 2017 at 11:16, Andres Freund <andres(at)anarazel(dot)de> wrote:
>>>
>>> Hi,
>>>
>>> On 2017-11-22 18:48:19 +0000, Simon Riggs wrote:
>>>>
>>>> Generational memory allocator
>>>>
>>>> Add new style of memory allocator, known as Generational
>>>> appropriate for use in cases where memory is allocated
>>>> and then freed in roughly oldest first order (FIFO).
>>>>
>>>> Use new allocator for logical decoding’s reorderbuffer
>>>> to significantly reduce memory usage and improve performance.
>>>
>>>
>>> Looks like it's not quite valgrind clean:
>>>
>>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2017-11-22%2022%3A30%3A01
>>
>>
>> It doesn't report anything useful that would allow me to fix this.
>>
>> Please enable some info reporting on the animal.
>>
>
> I agree it would be useful to get the valgrind log from the animal, but I
> guess you'd need to get valgrind working to fix the issue anyway.

If something fails compilation it tells us why, not just "compilation failed".

The whole point of the buildfarm is to report errors to allow them to
be fixed, not just a fence that blocks things.

> Anyway, the attached patch fixes the issues for me - strictly speaking the
> Assert is not needed, but it doesn't hurt.

Thanks for the patch.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services