Re: unicode test programs don't build with meson

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: unicode test programs don't build with meson
Date: 2024-10-30 07:32:05
Message-ID: c76aab32-c40e-4845-aa0e-05a49122e101@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 18.10.24 15:17, Aleksander Alekseev wrote:
>> 1) Add libintl directly to the affected programs, like
>>
>> case_test = executable('case_test',
>> ['case_test.c'],
>> - dependencies: [frontend_port_code, icu],
>> + dependencies: [frontend_port_code, icu, libintl],
>> include_directories: inc,
>> link_with: [common_static, pgport_static],
>> build_by_default: false,
>
> To me the first option seems to be the most natural one (does the
> program depend on the library? add it to the list of dependencies for
> this program). Also it seems to be most consistent with what we
> currently have, see how icu is listed.

As there were no other opinions forthcoming, I have committed it like
this. Thanks!

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Кириллов Вячеслав 2024-10-30 07:43:37 Re: Question about VACUUM behavior with sub-transactions in stored procedures
Previous Message Bertrand Drouvot 2024-10-30 07:26:07 Re: Add isolation test template in injection_points for wait/wakeup/detach