Re: unicode test programs don't build with meson

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>
Subject: Re: unicode test programs don't build with meson
Date: 2024-10-18 13:17:52
Message-ID: CAJ7c6TOFm6kgAop859TiUaXp6O9xwR-Dt8mu8U6qMqtGgFCBLQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Peter,

> 1) Add libintl directly to the affected programs, like
>
> case_test = executable('case_test',
> ['case_test.c'],
> - dependencies: [frontend_port_code, icu],
> + dependencies: [frontend_port_code, icu, libintl],
> include_directories: inc,
> link_with: [common_static, pgport_static],
> build_by_default: false,

To me the first option seems to be the most natural one (does the
program depend on the library? add it to the list of dependencies for
this program). Also it seems to be most consistent with what we
currently have, see how icu is listed.

--
Best regards,
Aleksander Alekseev

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2024-10-18 13:18:26 Re: Use more CppAsString2() in pg_amcheck.c
Previous Message Kirill Reshke 2024-10-18 12:42:43 Re: Amcheck verification of GiST and GIN