Re: Keep elog(ERROR) and ereport(ERROR) calls in the cold path

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Greg Nancarrow <gregn4422(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Keep elog(ERROR) and ereport(ERROR) calls in the cold path
Date: 2020-11-24 15:48:19
Message-ID: c4171207-43ca-548d-7d45-53358f95ca91@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-11-24 01:52, Dagfinn Ilmari Mannsåker wrote:
> The Clang documentation¹ suggest an even neater solution, which would
> eliminate the repetitive empty pg_attribute_foo #defines in the trailing
> #else/#endif block in commit 1fa22a43a56e1fe44c7bb3a3d5ef31be5bcac41d:
>
> #ifndef __has_attribute
> #define __has_attribute(x) 0
> #endif

Yes, this was also mentioned and agreed earlier in the thread, but then
we apparently forgot to update the patch.

--
Peter Eisentraut
2ndQuadrant, an EDB company
https://www.2ndquadrant.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2020-11-24 15:49:30 Re: abstract Unix-domain sockets
Previous Message Dilip Kumar 2020-11-24 15:47:02 Re: [HACKERS] Custom compression methods